A test for mismatching checked out git tag when publishing#1329
Merged
f-f merged 2 commits intopurescript:masterfrom Feb 14, 2025
Merged
A test for mismatching checked out git tag when publishing#1329f-f merged 2 commits intopurescript:masterfrom
f-f merged 2 commits intopurescript:masterfrom
Conversation
fsoikin
commented
Feb 10, 2025
| spago [ "fetch" ] >>= shouldBeSuccess | ||
| spago [ "publish", "-p", "root", "--offline" ] >>= shouldBeFailureErr (fixture "publish/1307-publish-dependencies/expected-stderr.txt") | ||
|
|
||
| Spec.describe "transfer" do |
Collaborator
Author
There was a problem hiding this comment.
GitHub doesn't show this diff in its most sensical way. The transfer section has been moved out to Transfer.purs and two tests right after it were indented one level to bring them back under publish.
This diff is best viewed with whitespace ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1109
When Spago tries to publish, and the currently checked out git tag doesn't match the
publish.versionconfig value, Spago errors out explaining the situation.The behavior itself has been in place for a while. This PR just adds a test for it.
While I was at it, I also took the opportunity to extract the
transfertests into their own fileTransfer.purs. They have been placed among thepublishtests, I'm assuming by mistake.Checklist:
[ ] Added the change to the "Unreleased" section of the changelog[ ] Added some example of the new feature to theREADME