Closed
Conversation
This reverts commit bf1dd54.
- Add darwin-amd64 and darwin-arm64 build targets - Use macOS runners for native builds with CGO enabled - Download and link wasmvm static library for macOS - Update installation instructions to include macOS binaries
- Remove manual wasmvm library download - Use 'make build' which handles all CGO dependencies correctly - Move binary from build/ to current directory for packaging
- Clear any leftover CGO_LDFLAGS, CGO_CFLAGS, and LIBRARY_PATH - Let the build system handle wasmvm library linking automatically
- Add version number to all release tar.gz filenames - Upload only tar.gz and sha256 files as artifacts (not directories) - Update download instructions with versioned URLs
- Fixed GitHub Actions workflow to use Makefile for proper version injection - Updated Docker builds to use existing Makefile instead of custom build commands - Updated macOS builds to use Makefile with version injection - Enhanced update detection to show architecture and binary filename - Removed GitHub API caching for real-time version checks - Fixed false update notifications for commit hash versions - Improved version comparison logic to handle commit hashes vs release versions 🤖 Generated with [Claude Code](https://claude.ai/code)
- Fixed GitHub Actions workflow to use Makefile for proper version injection - Updated Docker builds to use existing Makefile instead of custom build commands - Updated macOS builds to use Makefile with version injection - Enhanced update detection to show architecture and binary filename - Removed GitHub API caching for real-time version checks - Fixed false update notifications for commit hash versions - Improved version comparison logic to handle commit hashes vs release versions
…hchain/push-chain-node into feature/validator-node-setup
- Use quoted heredoc to prevent variable expansion in Dockerfile - Add ARG directives for VERSION and GOARCH in Dockerfile - Pass build arguments via --build-arg flags to docker buildx build - This should fix the v1.2.0 release build failure
This allows the workflow to trigger when the workflow file itself is modified, enabling testing of workflow fixes.
- Replace make build with direct go build command - Add proper ldflags for version injection - Use netgo and ledger build tags - This should fix cross-compilation issues with CGO and wasmvm
- Replace golang:1.23-alpine with golang:1.23 (GLIBC-based) - Replace apk with apt-get for Debian/Ubuntu package management - This fixes wasmvm linking errors with musl libc in Alpine Root cause: wasmvm library requires GLIBC symbols that are not available in Alpine's musl libc
✅ Docker build now succeeds with golang:1.23 (GLIBC-based image) ❌ Previous failures were due to wasmvm requiring GLIBC but Alpine using musl libc Ready to test full GitHub Actions workflow.
- Pin BINARY_VERSION to v1.1.0 to prevent ethsecp256k1 decoding issues - Add platform detection for future macOS support - Resolves panic: 'unable to resolve type URL /os.crypto.v1.ethsecp256k1.PubKey' - Ready for production deployment on Linux servers
- Add multi-architecture Dockerfile with proper platform detection - Create build-docker.sh script for cross-platform builds - Update push-node-manager to auto-detect Mac and use optimized builds - Support linux/amd64, linux/arm64, darwin/amd64, darwin/arm64 platforms - Pin binary version to v1.1.0 to resolve ethsecp256k1 compatibility issues - Add Docker buildx support for seamless Mac development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.