Merged
Conversation
zaryab2000
reviewed
May 23, 2025
zaryab2000
reviewed
May 23, 2025
zaryab2000
reviewed
May 23, 2025
src/MigrationLocker.sol
Outdated
| /// @notice Initializes the contract instead of constructor | ||
| /// @param _push The address of the PUSH token | ||
| /// @param initialOwner The address of the admin | ||
| function initialize( |
Collaborator
There was a problem hiding this comment.
safety check: initialOwner and push token address must be valid addresses.
zaryab2000
reviewed
May 23, 2025
zaryab2000
reviewed
May 23, 2025
src/MigrationLocker.sol
Outdated
| ) external onlyOwner onlyUnlocked { | ||
| require(_to != address(0), "Invalid recipient"); | ||
|
|
||
| if (_token == address(0)) { |
Collaborator
There was a problem hiding this comment.
there are no fallback or payable functions which allows entry of ETH to the contract. therefore, the logic for recovery of ETH from this contract is redundant.
zaryab2000
reviewed
May 23, 2025
zaryab2000
reviewed
May 23, 2025
zaryab2000
reviewed
May 23, 2025
src/MigrationRelease.sol
Outdated
| @@ -0,0 +1,182 @@ | |||
| // SPDX-License-Identifier: SEE LICENSE IN LICENSE | |||
| pragma solidity ^0.8.20; | |||
Collaborator
There was a problem hiding this comment.
use a fixed consistent version of solidity
zaryab2000
reviewed
May 23, 2025
…om/push-protocol/token_and_migration into 10-revamp-migration-wrt-push-chain
Zartaj0
force-pushed
the
10-revamp-migration-wrt-push-chain
branch
from
2640492 to
1dde6fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.