🐛 [BUG] - <FireFox UI flaws/issues>

[corlard3y]

Pull Request Template

#1952

Description

• UI issues(bugs) in FireFox browser

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior
  width: -webkit-fill-available not working in Firefox is due to the fact that Firefox does not support the -webkit- prefixed property. T

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

• In the import statements, 'Blocks.types' and 'colorBrands' seem to have incorrect paths. Please double-check the paths and make sure they are correct.
• In the styled component declaration, there is a comment about 'Responsive props' and 'Non-responsive props', but it seems that all the CSS properties inside are mixed and not separated according to responsiveness. Please organize them properly.
• In the CSS property 'color' and 'background-color', it's missing a fallback color or value if the props are not provided. Add a default color value in case props.color and props.backgroundColor are undefined.
• In the CSS property 'border-radius', the function 'getBlocksBorderRadius' is used, make sure it is defined and working correctly.
• In the CSS property 'border', the function 'getBlocksBorder' is used, ensure it is defined and functioning properly.
• The CSS for custom scrollbars seems correct, but make sure it is tested thoroughly for compatibility and usability.
• The 'extra CSS prop' seems fine, but ensure it's being used correctly and tested thoroughly.

Overall, the code structure and logic seem fine, but there are some areas that need to be reviewed and corrected. Once you make the necessary adjustments, please test the component thoroughly to ensure functionality.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-01-28 11:36 UTC