feat: add dns_cache_timeout, max_concurrent_streams, and modernize li… by puzza007 · Pull Request #165 · puzza007/katipo

puzza007 · 2025-12-27T00:09:53Z

…bevent

Add dns_cache_timeout option (0=disable, -1=forever, positive=seconds)
Add max_concurrent_streams pool option for HTTP/2 stream limits
Modernize libevent to 2.x API (event_base_new, bufferevent_socket_new)
Add proper cleanup on exit (bufferevent_free, curl_*_cleanup, event_base_free)
Fix curl type warnings (1L for CURLOPT_POST/NOBODY, long response_code)
Fix multi_timer_cb signature for curl type checking
Add COVERAGE=1 and SANITIZE=1 build flags to Makefile

Copilot

Pull request overview

This pull request adds DNS cache timeout and HTTP/2 max concurrent streams configuration options, modernizes the libevent integration to use the 2.x API, and improves resource cleanup. The PR also adds coverage build support and fixes curl type warnings for better type safety.

Added dns_cache_timeout request option with support for disabling (0), forever caching (-1), or custom timeout in seconds
Added max_concurrent_streams pool option for controlling HTTP/2 stream limits
Migrated from deprecated libevent 1.x API to modern 2.x API (event_base_new, bufferevent_socket_new, bufferevent_setcb)
Added proper cleanup code for bufferevents, curl handles, and event base on exit
Fixed curl type warnings by using 1L for boolean curl options and long for response codes
Added COVERAGE=1 build flag support with coverage target rules

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/katipo_SUITE.erl	Adds test cases for dns_cache_timeout option with different values and max_concurrent_streams pool option
src/katipo.erl	Adds dns_cache_timeout to request record and max_concurrent_streams to pool options type, implements validation and command line argument support
c_src/katipo.c	Migrates to libevent 2.x API, adds DNS cache timeout and max concurrent streams support, fixes curl type warnings, adds cleanup code
c_src/Makefile	Adds COVERAGE=1 build flag support with coverage HTML generation and cleanup targets
README.md	Documents dns_cache_timeout request option and max_concurrent_streams pool option with links to curl documentation
.gitignore	Adds C coverage artifacts to gitignore (gcda, gcno, gcov, coverage.info)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

c_src/Makefile

…bevent - Add dns_cache_timeout option (0=disable, -1=forever, positive=seconds) - Add max_concurrent_streams pool option for HTTP/2 stream limits - Modernize libevent to 2.x API (event_base_new, bufferevent_socket_new) - Add proper cleanup on exit (bufferevent_free, curl_*_cleanup, event_base_free) - Fix curl type warnings (1L for CURLOPT_POST/NOBODY, long response_code) - Fix multi_timer_cb signature for curl type checking - Add COVERAGE=1 and SANITIZE=1 build flags to Makefile

codecov · 2025-12-27T03:26:57Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

c_src/katipo.c

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

c_src/katipo.c

README.md

- Added explicit initialization - Changed to result.index (was sending garbage bytes) - Duplicate #include <getopt.h> - Redundant memset after calloc - Missing NULL check after realloc - Unused multi parameter in multi_timer_cb

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-28T03:17:37Z

src/katipo.erl

+                    userpwd => userpwd(),
+                    ca_cache_timeout => integer(),
+                    pipewait => boolean()}.


The new option dns_cache_timeout is missing from the opts() type specification. It should be added as "dns_cache_timeout => integer()" to match the implementation and the ca_cache_timeout and pipewait options that are already present.

Copilot · 2025-12-28T03:17:37Z

c_src/katipo.c

+#if LIBCURL_VERSION_NUM >= 0x074300 /* 7.67.0 */
+      case 's':
+        curl_multi_setopt(global.multi, CURLMOPT_MAX_CONCURRENT_STREAMS,
+                          atoi(optarg));
+        break;


The new 's' option for max-concurrent-streams is not included in the getopt_long short options string on line 1353. The string "pac:" should be updated to include 's' with a colon since it requires an argument (e.g., "pacs:"). Without this, the short option form will not work and getopt_long will treat 's' as an unknown option.

Copilot · 2025-12-28T03:17:37Z

c_src/katipo.c

+  if (CURLSHE_OK != curl_share_setopt(global.shobject, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS)) {
+    errx(2, "curl_share_setopt DNS failed");


DNS sharing is enabled in the global share object but the share object is only attached to individual curl easy handles when lock_data_ssl_session is true (line 899). This means DNS sharing won't work unless lock_data_ssl_session is enabled. The CURLOPT_SHARE should be set unconditionally, or the DNS sharing setup should be conditional on lock_data_ssl_session being enabled somewhere.

c_src/katipo.c

Copilot · 2025-12-28T03:17:38Z

src/katipo.erl

+                    userpwd => userpwd(),
+                    ca_cache_timeout => integer(),
+                    pipewait => boolean()}.


The new option dns_cache_timeout is missing from both the request() and opts() type specifications. It should be added as "dns_cache_timeout => integer()" to both type definitions to match the implementation and the ca_cache_timeout and pipewait options that are already present.

puzza007 requested a review from Copilot December 27, 2025 00:09

Copilot started reviewing on behalf of puzza007 December 27, 2025 00:10 View session

Copilot AI reviewed Dec 27, 2025

View reviewed changes

c_src/Makefile Show resolved Hide resolved

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from b52e502 to f7f4b81 Compare December 27, 2025 03:08

chore: code coverage

5a8fd7d

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from faa1b5d to 5a8fd7d Compare December 27, 2025 03:25

puzza007 added 2 commits December 28, 2025 07:12

feat: update libcurl error codes

9d4a024

feat: add ERRORBUFFER fallback

eec1e19

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from 8297715 to eec1e19 Compare December 27, 2025 18:12

puzza007 requested a review from Copilot December 27, 2025 18:19

Copilot started reviewing on behalf of puzza007 December 27, 2025 18:19 View session

Copilot AI reviewed Dec 27, 2025

View reviewed changes

c_src/katipo.c Show resolved Hide resolved

c_src/katipo.c Show resolved Hide resolved

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from 8ce6131 to 0510a4f Compare December 28, 2025 02:46

puzza007 requested a review from Copilot December 28, 2025 02:48

Copilot started reviewing on behalf of puzza007 December 28, 2025 02:49 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

c_src/katipo.c Show resolved Hide resolved

c_src/katipo.c Show resolved Hide resolved

README.md Show resolved Hide resolved

puzza007 added 7 commits December 28, 2025 16:07

chore: ei.h improvements

09c35bc

feat: ca_cache_timeout and pipewait

76ab454

fix: various C fixes

435da4e

- Added explicit initialization - Changed to result.index (was sending garbage bytes) - Duplicate #include <getopt.h> - Redundant memset after calloc - Missing NULL check after realloc - Unused multi parameter in multi_timer_cb

fix: error_logger was deprecated

990a568

fix: handle strings for capath and cacert

934e9c2

fix: use defines for magic numbers

215270e

chore: update maxredirs default in C

f0815a7

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from 3055906 to bbe2e37 Compare December 28, 2025 03:07

puzza007 requested a review from Copilot December 28, 2025 03:12

Copilot started reviewing on behalf of puzza007 December 28, 2025 03:12 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

feat: cache dns lookups

245b9a3

puzza007 added 4 commits December 28, 2025 16:37

chore: copilot review

8192279

chore: readme update

029e560

chore: shorter initialisation for easyopts

124f183

chore: c tidy

688ba41

puzza007 force-pushed the feat/dns-cache-timeout-and-improvements branch from e19d906 to 688ba41 Compare December 28, 2025 03:37

puzza007 merged commit 83ac708 into master Dec 28, 2025
6 checks passed

puzza007 deleted the feat/dns-cache-timeout-and-improvements branch December 28, 2025 04:03

		if (CURLSHE_OK != curl_share_setopt(global.shobject, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS)) {
		errx(2, "curl_share_setopt DNS failed");

Conversation

puzza007 commented Dec 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov bot commented Dec 27, 2025

Welcome to Codecov 🎉

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant