Skip to content

Let curl fail on non 2xx #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrira wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Let curl fail on non 2xx #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933dbb7
Let curl fail on non 2xx
RetGal Apr 29, 2025
a3934a1
curl without force to get http return code
chrira May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions helm/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ func (h *Helm) PackagePush(

if useNonOciHelmRepo {
curlCmd := []string{
`curl --variable %REGISTRY_USERNAME`,
`curl -f`,
`--variable %REGISTRY_USERNAME`,
`--variable %REGISTRY_PASSWORD`,
`--expand-user "{{REGISTRY_USERNAME}}:{{REGISTRY_PASSWORD}}"`,
`-T`,
Expand Down Expand Up @@ -277,7 +278,8 @@ func (h *Helm) doesChartExistOnRepo(
pkgFile := fmt.Sprintf("%s-%s.tgz", name, version)
// Do a GET of the chart but with response headers only so we do not download the chart
curlCmd := []string{
`curl --variable %REGISTRY_USERNAME`,
`curl`, // Do not use `-f` here because the returned http code is needed.
`--variable %REGISTRY_USERNAME`,
`--variable %REGISTRY_PASSWORD`,
`--expand-user "{{REGISTRY_USERNAME}}:{{REGISTRY_PASSWORD}}"`,
opts.getChartFqdn(pkgFile),
Expand Down
Loading