Implement GitHub Actions workflows for build, publish, and cleanup pr…#244
Merged
Implement GitHub Actions workflows for build, publish, and cleanup pr…#244
Conversation
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a suite of shell scripts and corresponding GitHub Actions workflows to manage building, signing, publishing, and cleaning up training application images and environments.
- Add reusable shell scripts for cosign verification, Helm deploy/remove, Kubernetes rollout, kubeconfig creation, and registry cleanup
- Introduce a unified
build-and-publish.yamlworkflow that builds, signs, verifies, deploys, and comments on PR environments - Implement a
pr-cleanup.yamlworkflow to tear down PR environments and clean up container registry artifacts
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/verify_cosign.sh | New script to verify image signatures via Sigstore cosign |
| scripts/remove_helm_release.sh | New script to uninstall Helm releases for PR environment cleanup |
| scripts/redeploy_deployment.sh | New script to trigger Kubernetes deployment rollouts |
| scripts/deploy_helm_release.sh | New script to install/upgrade Helm releases |
| scripts/create_kubeconfig.sh | New script to write KUBECONFIG from env var |
| scripts/cleanup_registry.sh | New script to delete tagged/untagged package versions via GH API |
| .github/workflows/pr-cleanup.yaml | Workflow to remove Helm release and registry tags on PR close |
| .github/workflows/build-and-publish.yaml | Consolidated workflow for building, signing, deploying, commenting |
Comments suppressed due to low confidence (4)
.github/workflows/pr-cleanup.yaml:14
- Using single quotes prevents
$HOMEfrom expanding; remove quotes or use double quotes (e.g.,"$HOME/.kube") so the path resolves correctly.
KUBE_CONFIG_PATH: '$HOME/.kube'
scripts/remove_helm_release.sh:5
- [nitpick] Other scripts use the
HELM_RELEASEvariable without theTRAINING_prefix; consider unifying on a single variable name for consistency across scripts.
: "${TRAINING_HELM_RELEASE:?Missing release name}"
.github/workflows/pr-cleanup.yaml:18
- Pin actions to a specific commit SHA rather than a floating tag for reproducible builds and to avoid unintentional upgrades.
uses: actions/checkout@v4
.github/workflows/build-and-publish.yaml:156
- Using
latestcan introduce unexpected changes; pin the Helm version to a known value for stability.
version: 'latest'
|
🚀 PR Environment: Open Deployment |
chrira
force-pushed
the
241-task-integrate-dagger-techlabs-cicd-pipeline
branch
from
2329551 to
94064ba
Compare
…anges; modify GitHub Actions workflow message format
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- Upgrade nginx base image to 1.28-alpine - Add nginx configuration file with security headers and server settings
…anges; modify GitHub Actions workflow message format
…anges; modify GitHub Actions workflow message format
chrira
force-pushed
the
241-task-integrate-dagger-techlabs-cicd-pipeline
branch
from
aae13aa to
2a442aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocesses