Skip to content

Small obvious improvements#16

Closed
Michalzr wants to merge 2 commits intopvlib:mainfrom
Michalzr:main
Closed

Small obvious improvements#16
Michalzr wants to merge 2 commits intopvlib:mainfrom
Michalzr:main

Conversation

@Michalzr
Copy link

@Michalzr Michalzr commented May 23, 2025

This PR contains some obvious improvements:

  • updated the path to the sample file in validate.py
  • updated the boundary description as discussed with Cliff. The boundary doesn't need to be a spline.
  • removed obsolete minOccurs="1" maxOccurs="1" -> it's the default

@Michalzr Michalzr changed the title Obvious improvements Small obvious improvements May 23, 2025
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michalzr

@Michalzr
Copy link
Author

Michalzr commented May 23, 2025

I see the automatic checks are failing, but they seem to be set up wrong.

Maybe I'll also look into that later.

Merging. EDIT: I don't have the rights to merge :)

@cwhanse
Copy link
Member

cwhanse commented May 23, 2025

The paths here need to be updated to point to Examples

@cwhanse cwhanse mentioned this pull request May 30, 2025
@cwhanse
Copy link
Member

cwhanse commented May 30, 2025

Closing, made obsolete by #18

@cwhanse cwhanse closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants