Merged
Conversation
cwhanse
reviewed
May 30, 2025
Member
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
@MichalZru if @stephane-pv agrees with my comments, we'll close this PR without merging.
MichalZru
force-pushed
the
fix/maxoccurs-cleanup
branch
from
c4f5f07 to
4808a56
Compare
Author
|
@cwhanse @stephane-pv I also added some fixes from PR https://github.com/pvlib/pvcollada/pull/16/files which you closed. |
cwhanse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stephane-pv @cwhanse
In this PR, I tried to resolve places where I think we had wrongly set up
maxOccurs.I updated the logic based on description in the comments. Please review