Additional validations #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for elements whose location was not specified
- Created a schematron file for validation of the basic structure of the document (making sure PVCollada elements are located in the "right" parent element, no duplicates allowed, etc) - Updated the validation workflow to also validate the example files against the schematron file on top of the XSD file - Updated the validation script located in the schema folder to validate files against the XSD and the schematron files
- Added instance_gap to schema - Made small adjustments to the schema documentation
Member
|
@stephane-pv I like where this is going. Do you think that the schematron validation is better as a separate github action? |
Added a new schematron file to validate references between PVCollada objects (for example making sure that the module_id used in the rack tag contains the id of an existing module defined in components/modulesc)
A table must have at least one rack
Added a new schematron file to validate business rules (for example making azimuth/tilt/tracker_azimuth fields required/forbidden in rack depending on rack type)
- Added cable3d to schema - Added instance_cable3d to schema - Added corresponding schema tron validation
XSD validation and schematron validations are now performed in different steps (1 step for XSD and 1 step for each schematron file)
Collaborator
Author
I have added steps so that each validation (XSD and schematron) is performed in a separate step. This way we can clearly see which one failed. |
cwhanse
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to add more automated validation for .pv2 files.
The idea is to keep the XSD 1.0 validation that comes built in with the schema, but to also enforce more complex rules like:
techniquetag withprofile='PVCollada-2.0'projectcan only appear inCOLLADA/asset/extra/technique,terraincan only appear ingeometry/extra/technique, etc)techniquetags withprofile='PVCollada-2.0'under the same parent, we cannot have 2projecttags, we cannot haveterrainandracktags under the samegeometry, etc)instance_posttag is under aninstance_geometrytag that correctly references (through#url) a Colladageometrytag that has PVColladaposttagtablecontains at least oneinstance_geometrychild with aracktagrackwe want to havetiltandazimuthrequired forfixed_tiltwhiletracker_azimuthwould be required fortracker)A first attempt will be made with SchemaTron and a python validation script will be provided for easily validating any file against the XSD file and the SchemaTron file.
The automatic validation workflow will also be modified to validate all example files against the XSD file and the SchemTron file