Skip to content

Conversation

@kandersolar
Copy link
Member

@kandersolar kandersolar commented Nov 5, 2020

  • Closes Adjustable attributes for get_psm3 #1079
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

I'm lumping a few get_psm3 updates into this PR:

I'm not wild about including a 10MB csv file for the test -- okay to trim it down to a single day, or fine as is?

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to cut the csv down to just a day. I've done that for a lot of the other test files.

@wholmgren wholmgren added this to the 0.8.1 milestone Nov 6, 2020
@wholmgren wholmgren added the io label Nov 6, 2020
@wholmgren wholmgren merged commit 11c356f into pvlib:master Nov 9, 2020
@kandersolar kandersolar deleted the psm3 branch November 18, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjustable attributes for get_psm3

2 participants