Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Dec 15, 2020

  • Closes add python 3.9 to ci configuration #1102
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

All of the base functionality works. Optional functionality that does not work:

  • The forecast.py code needs netcdf4. As of now, netcdf4 needs a different build of numpy than would otherwise be pulled by the environment solver. This build of numpy spits out an ImportError on my mac.
  • Numba is not yet compatible with 3.9.
  • pysam installation issue on windows. Maybe related to Pip install causing "SAMNIDIR" error NREL/pysam#56. The easiest way to deal with this is to comment out the pysam line in the environment file and thus skip it on all platforms. That's my preference.

@wholmgren wholmgren added this to the 0.8.1 milestone Dec 15, 2020
@kandersolar
Copy link
Member

Guessing the installation failure is related to NREL/pysam#68

@cwhanse
Copy link
Member

cwhanse commented Dec 15, 2020

The easiest way to deal with this is to comment out the pysam line in the environment file and thus skip it on all platforms. That's my preference.

OK with me.

@wholmgren
Copy link
Member Author

I think this is ok to merge.

@wholmgren
Copy link
Member Author

Guessing the installation failure is related to NREL/pysam#68

CI installs nrel-pysam using pip, so it's not clear to me how they're related.

@wholmgren wholmgren merged commit 6e936f5 into pvlib:master Dec 17, 2020
@wholmgren wholmgren deleted the py39ci branch December 17, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add python 3.9 to ci configuration

3 participants