Skip to content

Make sure times are assigned with ModelChain.run_from_poa #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Make sure times are assigned with ModelChain.run_from_poa #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b33f8d
Make sure times are assigned with ModelChain.run_from_poa
alorenzo175 Feb 5, 2021
e420dc4
move _assign_times to _assign_weather
alorenzo175 Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,6 +1324,7 @@ def _build_weather(data):
_build_weather(weather) for weather in data
)
self._configure_results()
self._assign_times()
return self

def _assign_total_irrad(self, data):
Expand Down Expand Up @@ -1392,7 +1393,6 @@ def prepare_inputs(self, weather):
self._check_multiple_input(weather, strict=False)
self._verify_df(weather, required=['ghi', 'dni', 'dhi'])
self._assign_weather(weather)
self._assign_times()

self._prep_inputs_solar_pos(weather)
self._prep_inputs_airmass()
Expand Down
1 change: 1 addition & 0 deletions pvlib/tests/test_modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,7 @@ def test_prepare_inputs_from_poa(sapm_dc_snl_ac_system, location,
assert_frame_equal(mc.weather, weather_expected)
# total_irrad attribute
assert_frame_equal(mc.results.total_irrad, total_irrad)
assert not pd.isnull(mc.results.solar_position.index[0])


@pytest.mark.parametrize("input_type", [tuple, list])
Expand Down