Skip to content

Get test_aoi_and_aoi_projection passing on numpy 1.22.0 #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Get test_aoi_and_aoi_projection passing on numpy 1.22.0 #1369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1831068
see if magic numpy env var to disable AVX512 gets tests passing again
kandersolar Jan 6, 2022
0e891b9
loosen test tolerance; remove magic numpy env var
kandersolar Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ def test_aoi_and_aoi_projection(surface_tilt, surface_azimuth, solar_zenith,
aoi_proj_expected):
aoi = irradiance.aoi(surface_tilt, surface_azimuth, solar_zenith,
solar_azimuth)
assert_allclose(aoi, aoi_expected, atol=1e-6)
assert_allclose(aoi, aoi_expected, atol=1e-5)
Copy link
Member Author

@kandersolar kandersolar Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwhanse any objection to just bumping this tolerance to 1e-5?

Copy link
Member

@cwhanse cwhanse Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection


aoi_projection = irradiance.aoi_projection(
surface_tilt, surface_azimuth, solar_zenith, solar_azimuth)
Expand Down