Advance numpy from 1.12.0 to 1.16.0 #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
setup.py, the other ci/requirements files, and benchmarks/asv.conf.json need the new version as well |
Member
Author
|
Advancing numpy exposed two tests that should have failed, not sure why they were passing before. |
kandersolar
approved these changes
Feb 9, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Strange about the tests. I don't know why they were passing either.
Co-authored-by: Kevin Anderson <[email protected]>
Member
Author
|
Based on comments on #1399 it appears we're in agreement. I'll merge tomorrow unless objections are raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Advance numpy to 1.16.0 or later. Repair some poorly formed tests for inverter.py.