Skip to content

Conversation

@JackKelly
Copy link
Contributor

@JackKelly JackKelly commented Feb 25, 2022

A tiny PR! Just fixing a tiny typo in the docs 🙂

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse cwhanse added this to the 0.9.1 milestone Feb 25, 2022
@cwhanse
Copy link
Member

cwhanse commented Feb 25, 2022

Thanks @JackKelly can you add your name to the contributor list in whatsnew/v0.9.1 ?

@JackKelly
Copy link
Contributor Author

Thanks for approving this pull request 🙂

I've just added myself to the list of contributors. Thank you!

@cwhanse cwhanse merged commit 46e11a9 into pvlib:master Feb 28, 2022
@wholmgren
Copy link
Member

thanks @JackKelly!

@JackKelly
Copy link
Contributor Author

thanks @JackKelly!

hehe, thank you guys for creating such an awesome library! Sorry this first PR is so meagre. I hope to contribute in a more meaningful way soon 🙂

@JackKelly JackKelly deleted the patch-1 branch February 28, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants