Skip to content

Conversation

@hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein commented May 21, 2022

  • Relates to LGTM has 6 errors  #1275 but does not fix all the issues
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue

This addresses 1 of the problems from pvlib#1275; The easiest tbh
@hf-kklein hf-kklein marked this pull request as ready for review May 21, 2022 08:02
@cwhanse cwhanse added the bug label May 22, 2022
@cwhanse cwhanse added this to the 0.9.2 milestone May 22, 2022
@cwhanse
Copy link
Member

cwhanse commented May 22, 2022

Thanks @hf-kklein for this bit of clean up.

@hf-kklein
Copy link
Contributor Author

the label "easy first problem" was no exaggeration in that case :D

@kandersolar kandersolar merged commit 91986b9 into pvlib:master Jun 13, 2022
@hf-kklein hf-kklein deleted the remove_self_assignment branch June 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants