Skip to content

Allow read_tmy3 to handle 00:00 timestamps #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 16, 2022
Merged

Allow read_tmy3 to handle 00:00 timestamps #1494

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ba44bea
Update read_tmy3 date shift
AdamRJensen Jul 19, 2022
7ca07dd
Add test coverage
AdamRJensen Jul 22, 2022
ae660a3
Add whatsnew entry
AdamRJensen Jul 22, 2022
b591994
Clean up TMY3 table
AdamRJensen Jul 22, 2022
7a5bd5c
Add comments to test files
AdamRJensen Jul 22, 2022
2715844
Fix stickler
AdamRJensen Jul 22, 2022
030b0e2
Update admonition
AdamRJensen Jul 22, 2022
b99848b
Apply changes from kanderso-nrel
AdamRJensen Jul 25, 2022
611a28f
Add encoding option to read_tmy3
AdamRJensen Jul 26, 2022
b889425
Fix stickler
AdamRJensen Jul 26, 2022
f610686
Update pvlib/iotools/tmy.py
AdamRJensen Jul 26, 2022
1630e2d
Remove encoding parameter and add try/except
AdamRJensen Jul 26, 2022
94016b3
Update tmy.py
AdamRJensen Jul 26, 2022
a5f0422
Fix incorrect parenthesis
AdamRJensen Jul 26, 2022
e812dae
Add fbuf.close and first within try/except
AdamRJensen Jul 27, 2022
338745f
Add finally clause
AdamRJensen Jul 27, 2022
1affb8c
Utilize open and add _parse_tmy3
AdamRJensen Jul 29, 2022
4788c96
Fix stickler
AdamRJensen Jul 29, 2022
f802b5e
Merge branch 'master' into update_tmy3
AdamRJensen Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/sphinx/source/whatsnew/v0.9.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ Bug fixes
where passing localized timezones with large UTC offsets could return
rise/set/transit times for the wrong day in recent versions of ``ephem``
(:issue:`1449`, :pull:`1448`)

* :py:func:`pvlib.iotools.read_tmy3` is now able to accept midnight
timestamps as either 24:00 (which is the standard) as well as 00:00.
Previously 00:00 timestamps would incorrectly be moved one day forward.
(:pull:`1494`)

Testing
~~~~~~~
Expand All @@ -34,7 +37,6 @@ Documentation
* Add gallery example of simulating rearside irradiance for a fixed-tilt
array with pvfactors (:pull:`1470`)


Benchmarking
~~~~~~~~~~~~~
* Updated version of numba in asv.conf from 0.36.1 to 0.40.0 to solve numba/numpy conflict. (:issue:`1439`, :pull:`1440`)
Expand Down
Loading