Skip to content

Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 11, 2022
Merged

Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e62b27
don't think we need the sed/tee stuff
kandersolar Aug 31, 2022
a4f8f8d
better asv workflow job name
kandersolar Aug 31, 2022
494d9ea
don't call setup.py for pvlib build
kandersolar Aug 31, 2022
1ab1794
fiddling
kandersolar Aug 31, 2022
74669bb
fiddle
kandersolar Aug 31, 2022
afea860
verbose
kandersolar Aug 31, 2022
634d3e7
fiddle
kandersolar Aug 31, 2022
66c0ddd
clean up the mess
kandersolar Aug 31, 2022
7deb259
push: only trigger for master branch
kandersolar Aug 31, 2022
3df1b03
tabs vs spaces...
kandersolar Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/asv_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
name: asv

# CI ASV CHECK is aimed to verify that the benchmarks execute without error.
on: [pull_request, push]
on:
push:
branches:
- master
pull_request:


jobs:
quick:
quick-benchmarks:
runs-on: ubuntu-latest
defaults:
run:
Expand All @@ -27,8 +32,4 @@ jobs:
run: |
cd benchmarks
asv machine --yes
asv run HEAD^! --quick --dry-run --show-stderr | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
if grep "failed" benchmarks.log > /dev/null ; then
exit 1
fi

asv run HEAD^! --quick --dry-run --show-stderr
9 changes: 5 additions & 4 deletions benchmarks/asv.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
//
// "install_command": ["in-dir={env_dir} python -mpip install {wheel_file}"],
// "uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],
// "build_command": [
// "python setup.py build",
// "PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"
// ],
"build_command": [
"python -m build -o {build_cache_dir}",
],

// List of branches to benchmark. If not provided, defaults to "master"
// (for git) or "default" (for mercurial).
Expand Down Expand Up @@ -115,6 +114,7 @@
// minimum supported versions
{
"python": "3.7",
"build": "",
"numpy": "1.16.0",
"pandas": "0.25.0",
"scipy": "1.2.0",
Expand All @@ -126,6 +126,7 @@
// latest versions available
{
"python": "3.8",
"build": "",
"numpy": "",
"pandas": "",
"scipy": "",
Expand Down