Skip to content

Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5240283
Fixed test_irradiance.py::test_get_ground_diffuse_albedo_0 test asse…
bowie2211 Oct 20, 2022
062ca7f
Whats new entry for fixed test_irradiance.py::test_get_ground_diffuse…
bowie2211 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/sphinx/source/whatsnew/v0.9.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Bug fixes

Testing
~~~~~~~

* Corrected a flawed test for :py:func:`~pvlib.irradiance.get_ground_diffuse` (:issue:`1569`, :pull:`1575`)

Documentation
~~~~~~~~~~~~~
Expand All @@ -34,4 +34,5 @@ Requirements

Contributors
~~~~~~~~~~~~
* Christian Orner (:ghuser:`chrisorner`)
* Christian Orner (:ghuser:`chrisorner`)
* Marcus Boumans (:ghuser:`bowie2211`)
2 changes: 1 addition & 1 deletion pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_get_ground_diffuse_simple_series(irrad_data):
def test_get_ground_diffuse_albedo_0(irrad_data):
ground_irrad = irradiance.get_ground_diffuse(
40, irrad_data['ghi'], albedo=0)
assert 0 == ground_irrad.all()
assert (0 == ground_irrad).all()


def test_get_ground_diffuse_albedo_series(times):
Expand Down