Skip to content

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Nov 2, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar
Copy link
Member

@wholmgren bumping actions/setup-python from v1 to v4 made 3.11 available when I tried this a few days ago. After that, the blocker is that h5py hasn't yet released 3.11 wheels: h5py/h5py#2165

Also I think the new filename requirements-py-3.11.yml has an extra hyphen in py-3.11 that needs to be removed.

@wholmgren
Copy link
Member Author

@kanderso-nrel thanks! should I close this in favor of a better developed branch of yours? feel free to push to this branch too.

@kandersolar
Copy link
Member

Let's just keep this one

@kandersolar kandersolar added this to the 0.9.5 milestone Dec 14, 2022
@kandersolar kandersolar reopened this Jan 23, 2023
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h5py 3.11 wheels are out! h5py/h5py#2146

@wholmgren wholmgren marked this pull request as ready for review January 24, 2023 03:23
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should re-evaluate the commented-out packages in all the conda environment files at some point but doesn't have to be now.

@wholmgren
Copy link
Member Author

@kanderso-nrel I cleaned up some CI specs. Worth another look. Then I think you can go ahead and merge.

@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Jan 24, 2023
@kandersolar
Copy link
Member

We forgot to add 3.11 to the pytest-remote-data config, but otherwise LGTM. Thanks for the non-3.11 cleanup as well!

@kandersolar kandersolar merged commit b11c9e2 into pvlib:main Jan 24, 2023
@wholmgren wholmgren deleted the py311 branch January 24, 2023 17:40
@kandersolar kandersolar mentioned this pull request Jun 14, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote-data triggers --remote-data pytests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants