Skip to content

Conversation

@kandersolar
Copy link
Member

@kandersolar kandersolar commented Dec 5, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I just noticed that the CI hasn't been running on main for the last several commits, likely because of renaming our primary branch but not updating the CI configs. We also have a ton of broken links scattered through the docs. This PR goes through and updates all those things.

@kandersolar kandersolar marked this pull request as ready for review December 5, 2022 18:44
@kandersolar kandersolar added this to the 0.9.4 milestone Dec 5, 2022
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Dec 5, 2022
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fairly extensive search for "master" and all your changes checks out.

@wholmgren
Copy link
Member

@kanderso-nrel merge it?

@kandersolar kandersolar merged commit df8055e into pvlib:main Dec 8, 2022
@kandersolar
Copy link
Member Author

Thanks folks!

@kandersolar kandersolar deleted the ci-fix branch December 8, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants