fix error in test_get_sun_rise_set_transit #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released pandas 0.18.1 changed the way that
pd.to_datetimehandles fractions of seconds, which caused thetest_get_sun_rise_set_transitfunction to fail since the expected times were specified to microseconds. This PR changes the expected times only have 1 second precision, and rounds the output ofget_sun_rise_set_transitfor the test. The problem is that the Timestamp rounding doesn't work on pandas 0.13-0.16. I don't want to raise the version requirements just for this test, so it gets a skip decorator instead. It's a bad hack that I'll try to revisit after the workshop.