Skip to content

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Dec 24, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

We're looking into optimizations for these functions, so here's a PR to track performance.

I needed to bump the minimum numpy to create a conda environment on my mac. I think it's ok that it's a little inconsistent with the true minimum requirements. I also bumped the minimum h5py for consistency with the min conda yml file.

@wholmgren wholmgren added this to the 0.9.5 milestone Dec 24, 2022
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wholmgren!

@wholmgren wholmgren merged commit 5b05914 into pvlib:main Dec 29, 2022
@wholmgren wholmgren deleted the infshedsbench branch December 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants