Skip to content

Conversation

@cwhanse
Copy link
Member

@cwhanse cwhanse commented May 4, 2023

  • Closes Clarify f_x #1677
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Replaces #1701

@cwhanse cwhanse added this to the 0.9.6 milestone May 4, 2023
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are some unrelated conda issue. Thanks @Lakshyadevelops!

@kandersolar kandersolar merged commit 275e671 into pvlib:main May 4, 2023
@kandersolar kandersolar mentioned this pull request May 4, 2023
3 tasks
@kandersolar kandersolar modified the milestones: 0.9.6, 0.10.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify f_x

3 participants