Skip to content

Format equation text in ivtools/sde.py #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

Format equation text in ivtools/sde.py #1750

merged 1 commit into from
May 26, 2023

Conversation

@cwhanse
Copy link
Member

@cwhanse cwhanse commented May 25, 2023 •
edited
Loading

  • I am familiar with the contributing guidelines
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Missed a line break in an equation in the docstring

@cwhanse cwhanse added this to the 0.10.0 milestone May 25, 2023
kandersolar
kandersolar approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: https://pvlib-python--1750.org.readthedocs.build/en/1750/reference/generated/pvlib.ivtools.sde.fit_sandia_simple.html

@kandersolar kandersolar merged commit 5596be3 into pvlib:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kandersolar kandersolar kandersolar approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cwhanse @kandersolar