Skip to content

Solve alleged twine warnings on pypi publishing #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Solve alleged twine warnings on pypi publishing #1778

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e37767
Solve twine warning
echedey-ls Jun 18, 2023
f55643f
Add metadata verification to publish.yml
echedey-ls Jul 7, 2023
1a5aff7
Add twine to build tools
echedey-ls Jul 7, 2023
f6705a0
code review
echedey-ls Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,21 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install build
python -m pip install twine

- name: Build packages
run: python -m build

- name: Check metadata verification
run: python -m twine check dist/*

# only publish distribution to PyPI for tagged commits
- name: Publish distribution to PyPI
if: startsWith(github.ref, 'refs/tags/v')
uses: pypa/gh-action-pypi-publish@release/v1
with:
# do not run twine check by default
# to avoid duplicated output
verify-metadata: false
user: __token__
password: ${{ secrets.pypi_password }}
password: ${{ secrets.pypi_password }}
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

Source code: https://github.com/pvlib/pvlib-python
"""
LONG_DESCRIPTION_CONTENT_TYPE = "text/plain"

DISTNAME = 'pvlib'
LICENSE = 'BSD 3-Clause'
Expand Down Expand Up @@ -120,6 +121,7 @@
ext_modules=extensions,
description=DESCRIPTION,
long_description=LONG_DESCRIPTION,
long_description_content_type=LONG_DESCRIPTION_CONTENT_TYPE,
author=AUTHOR,
maintainer_email=MAINTAINER_EMAIL,
license=LICENSE,
Expand Down