Skip to content

Allow dates to be strings in iotools get functions #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2023
Merged

Allow dates to be strings in iotools get functions #1800

merged 6 commits into from
Jul 13, 2023

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jul 1, 2023 •
edited
Loading

  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR allows for the start/end parameters in the iotools get functions to be specified as strings.

@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Jul 1, 2023
@AdamRJensen AdamRJensen added this to the 0.10.1 milestone Jul 1, 2023
@kandersolar kandersolar modified the milestones: 0.10.1, v0.10.2 Jul 6, 2023
@AdamRJensen AdamRJensen requested a review from kandersolar July 6, 2023 13:58
kandersolar
kandersolar approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamRJensen AdamRJensen merged commit 3aa2c4d into pvlib:main Jul 13, 2023
@AdamRJensen AdamRJensen deleted the allow_string_date_iotools branch July 13, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Milestone
v0.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamRJensen @kandersolar