Skip to content

Conversation

kandersolar
Copy link
Member

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The PSM3 request-side variable map incorrectly translates pvlib's ghi_clear to PSM3's clearsky_dhi instead of clearsky_ghi. Simple fix.

@kandersolar kandersolar added this to the v0.10.2 milestone Aug 1, 2023
@kandersolar kandersolar requested a review from AdamRJensen August 1, 2023 14:20
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Feel free to merge.

@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Aug 1, 2023
@kandersolar kandersolar merged commit 996361d into pvlib:main Aug 1, 2023
@kandersolar kandersolar deleted the psm3-ghi-cs branch August 1, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants