Skip failing SRML tests #1921
Merged
Skip failing SRML tests #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
+1 from me to skip these tests until the website comes back. I think we (mostly Adam) are in enough contact with Josh at SRML that we will hear when the website is back up and we can reinstate these tests.
Thanks @AdamRJensen! This will save many CI hours.
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.The remote data tests in iotools/test_srml.py have been failing for a while. However, the tests first fail after running for a very long time (hours?) which makes testing difficult. The reason is that the SRML website is currently undergoing maintenance - it's unknown when it will be back up and running.
Thus, as a temporary solution, I suggest we mark the remote data SRML tests with
@pytest.mark.skipand create an issue as a reminder to re-enable these tests when the SRML website comes back online.