fix a typo at the singlediode function #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can any maintainer please approve workflows when possible? TIA. |
mikofski
reviewed
Aug 28, 2024
pvlib/singlediode.py
Outdated
| @@ -632,7 +632,7 @@ def _shape_of_max_size(*args): | |||
| def _prepare_newton_inputs(x0, args, method_kwargs): | |||
| """ | |||
| Make inputs compatible with Scipy's newton by: | |||
| - converting all arugments (`x0` and `args`) into numpy.ndarrays if any | |||
| - converting all arguments (`x0` and `args`) into numpy.ndarrays if any | |||
There was a problem hiding this comment.
Remove trailing white space please
cwhanse
reviewed
Sep 11, 2024
space removed Co-authored-by: Cliff Hansen <[email protected]>
cwhanse
approved these changes
Sep 11, 2024
|
Thanks @luizreiscver! We hope to see more contributions from you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.