Skip to content

get_sky_diffuse documentation updated (ValueError description) #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

get_sky_diffuse documentation updated (ValueError description) #2187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3997765
documentation updated
BernatNicolau Aug 28, 2024
6bbf7d1
added comma
BernatNicolau Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,8 @@ def get_sky_diffuse(surface_tilt, surface_azimuth,
Raises
------
ValueError
If model is one of ``'haydavies'``, ``'reindl'``, or ``'perez'`` and
``dni_extra`` is not specified.
If model is one of ``'haydavies'``, ``'reindl'``, ``'perez'``, or
``'perez_driesse'`` and ``dni_extra`` is not specified.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comma is needed after 'perez_driesse' since the absence of dni_extra applies to each of the models.


Notes
-----
Expand Down
Loading