Skip to content

Conversation

hamiltonkibbe
Copy link
Contributor

@hamiltonkibbe hamiltonkibbe commented Nov 26, 2024

The link in the Pull request template was invalid, this corrects it.

It seems that at some point the route was moved from contributing.html to contributing/index.html...

  • Closes Contribution Guidelines link in PR Template is Broken #2307
  • I am familiar with the contributing guidelines :)
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The link in the Pull request template was invalid, this corrects it.
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamiltonkibbe!

@kandersolar kandersolar merged commit 7abccda into pvlib:main Nov 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution Guidelines link in PR Template is Broken
2 participants