Skip to content

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Nov 27, 2024

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I just always thought this would be useful after working on #2018

@echedey-ls echedey-ls added this to the v0.11.2 milestone Nov 27, 2024
@kandersolar
Copy link
Member

@echedey-ls something is wrong with the rendering, check here: https://pvlib-python--2313.org.readthedocs.build/en/2313/reference/generated/pvlib.pvsystem.retrieve_sam.html

The problem might be the blank line, but I am not sure.

@echedey-ls
Copy link
Contributor Author

The problem might be the blank line, but I am not sure.

@kandersolar you were right. I've done some pretty formatting to the docstring too.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvements @echedey-ls!

@kandersolar kandersolar merged commit 9c87e5e into pvlib:main Dec 3, 2024
26 checks passed
@echedey-ls echedey-ls deleted the example4retrieve_sam branch December 3, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants