Skip to content

Fix failing asv benchmarks in CI #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Fix failing asv benchmarks in CI #2352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
136046a
Pin asv to latest to fix conda install breakage
markcampanelli Jan 10, 2025
582386e
Update whatsnew
markcampanelli Jan 10, 2025
94a59dc
Address reviewer comments
markcampanelli Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .github/workflows/asv_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,7 @@ jobs:
python-version: '3.9'

- name: Install asv
run: pip install asv==0.4.2

# asv 0.4.2 (and more recent versions as well) creates conda envs
# using the --force option, which was removed in conda 24.3.
# Since ubuntu-latest now comes with conda 24.3 pre-installed,
# using the system's conda will result in error.
# To prevent that, we install an older version.
# TODO: remove this when we eventually upgrade our asv version.
# https://github.com/airspeed-velocity/asv/issues/1396
- name: Install Conda
uses: conda-incubator/setup-miniconda@v3
with:
conda-version: 24.1.2
run: pip install asv==0.6.4

- name: Run asv benchmarks
run: |
Expand Down
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.11.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@ Testing

Requirements
~~~~~~~~~~~~
* asv 0.4.2 upgraded to asv 0.6.4 to fix CI install failure due to pinned older conda.
(pull:`2352`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* asv 0.4.2 upgraded to asv 0.6.4 to fix CI install failure due to pinned older conda.
(pull:`2352`)
* asv 0.4.2 upgraded to asv 0.6.4 to fix CI failure due to pinned older conda.
(pull:`2352`)

It sounds weird to me; like if it were the CI what you were installing.
In any case, that's not important. Can you move this to the Testing section? Or create a new one called Maintenance? I feel like requirements is more about dependencies an user would normally install.



Contributors
~~~~~~~~~~~~
* Mark Campanellli (:ghuser:`markcampanelli`)


Loading