Skip to content

Fix for the different results for Procedural and Object oriented exam… #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix for the different results for Procedural and Object oriented exam… #2367

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b52aea
Fix for the different results for Procedural and Object oriented exam…
manojks1999 Jan 27, 2025
794f71f
Updated the docs
manojks1999 Jan 29, 2025
a49dbee
Change in docs
manojks1999 Jan 30, 2025
e1bec11
Merge branch 'main' into fix_procedural_and_obj_call
cwhanse Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sphinx/source/user_guide/introtutorial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ to accomplish our system modeling goal:
longitude=longitude,
altitude=altitude,
temperature=weather["temp_air"],
pressure=pvlib.atmosphere.alt2pres(altitude),
pressure=weather["pressure"],
)
dni_extra = pvlib.irradiance.get_extra_radiation(weather.index)
airmass = pvlib.atmosphere.get_relative_airmass(solpos['apparent_zenith'])
Expand Down
4 changes: 3 additions & 1 deletion docs/sphinx/source/whatsnew/v0.11.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Enhancements

Documentation
~~~~~~~~~~~~~

* :py:meth:`~pvlib.solarposition.get_solarposition` Changes for different results for Procedural and Object oriented examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :py:meth:`~pvlib.solarposition.get_solarposition` Changes for different results for Procedural and Object oriented examples
* Fix Procedural and Object Oriented simulation examples having slightly different results, in :ref:`introtutorial`.

(:issue:`2366`, :pull:`2367`)

Testing
~~~~~~~
Expand All @@ -36,3 +37,4 @@ Contributors
~~~~~~~~~~~~
* Rajiv Daxini (:ghuser:`RDaxini`)
* Mark Campanelli (:ghuser:`markcampanelli`)
* Manoj K S (:ghuser: `manojks1999`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Manoj K S (:ghuser: `manojks1999`)
* Manoj K S (:ghuser:`manojks1999`)