Remove unnecessary SAPM keys in pvsystem._DC_MODEL_PARAMS
#2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
reviewed
Mar 4, 2025
| 'Isco', 'Impo', 'Voco', 'Vmpo', 'Aisc', 'Aimp', 'Bvoco', | ||
| 'Mbvoc', 'Bvmpo', 'Mbvmp', 'N', 'Cells_in_Series', | ||
| 'IXO', 'IXXO', 'FD'}, | ||
| 'IXO', 'IXXO'}, |
There was a problem hiding this comment.
I've long wanted to move 'IX0' and 'IX00' into some kind of optional category, to allow the SAPM electrical model to run without them. That would be scope expansion in this PR; the thought resurfaces when I read "unnecessary SAPM keys" and "minimal set of parameters".
cwhanse
approved these changes
Mar 7, 2025
|
merge when ready @kandersolar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvsystem._DC_MODEL_PARAMSlists unnecessary parameters for SAPM #2369- [ ] Tests added- [ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).- [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.