Skip to content

Fix dtypes in get_pvgis_tmy when outputformat='epw' #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Fix dtypes in get_pvgis_tmy when outputformat='epw' #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b5b644
Fix dtypes in get_pvgis_tmy when outputformat='epw'
AdamRJensen Mar 22, 2025
1b4b98d
Fix linter
AdamRJensen Mar 22, 2025
f14ef76
Add GH # comment in code
AdamRJensen Apr 7, 2025
0683c92
Undo review change
AdamRJensen Apr 14, 2025
97e503c
Merge remote-tracking branch 'upstream/main' into fix_get_pvgis_tmy_e…
AdamRJensen May 22, 2025
85bb8ad
Update v0.12.1.rst
AdamRJensen May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/v0.12.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ Breaking Changes

Bug fixes
~~~~~~~~~

* :py:func:`pvlib.iotools.get_pvgis_tmy` now returns the correct dtypes when
when ``outputformat='epw'``. (:issue:`2399`, :pull:`2417`)

Enhancements
~~~~~~~~~~~~
Expand Down
3 changes: 3 additions & 0 deletions pvlib/iotools/pvgis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ def _coerce_and_roll_tmy(tmy_data, tz, year):
np.roll(tmy_data, tz, axis=0),
columns=tmy_data.columns,
index=new_index)
# GH 2399
new_tmy_data = \
new_tmy_data.astype(dtype=dict(zip(tmy_data.columns, tmy_data.dtypes)))
return new_tmy_data


Expand Down
Loading