Skip to content

Conversation

kandersolar
Copy link
Member

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Looks like SolarAnywhere made slight adjustments to the error messages returned by their API. A test is failing with

FAILED tests/iotools/test_solaranywhere.py::test_get_solaranywhere_not_available - AssertionError: Regex pattern did not match.
 Regex: 'Tile is outside of our coverage'
 Input: 'Location is outside of our coverage area (Latitude = 40, Longitude = -70)'

Example CI failure: https://github.com/pvlib/pvlib-python/actions/runs/14497459980/job/40668716357

@kandersolar kandersolar added io remote-data triggers --remote-data pytests labels Apr 16, 2025
@kandersolar kandersolar added this to the v0.12.1 milestone Apr 16, 2025
@kandersolar kandersolar merged commit 580037a into pvlib:main Apr 18, 2025
48 checks passed
@kandersolar kandersolar deleted the solaranywhere-fix branch April 18, 2025 12:36
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants