Change get_pvgis_tmy coerce_year default to 1990 #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamRJensen
added
remote-data
AdamRJensen
added
remote-data
kandersolar
reviewed
Jun 5, 2025
Co-authored-by: Kevin Anderson <[email protected]>
AdamRJensen
added
remote-data
kandersolar
approved these changes
Jun 5, 2025
Co-authored-by: Kevin Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR changes the default value of
coerce_yearfrom None to 1990 in thepvlib.iotools.get_pvgis_tmyfunction. This is a breaking change and is not deprecated since it will be part of the same release as other breaking changes to the function that cannot be deprecated (see #2470).The desire for this change is that the
get_pvgis_tmyfunction is commonly used for introductory tutorials, where beginners often waste a lot of time on getting "strange" plots because the TMY indexes span +10 years.