Skip to content

Conversation

IoannisSifnaios
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios commented Jul 15, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR adds a function to get irradiance and weather data from NASA POWER. read_the_docs_link

@IoannisSifnaios IoannisSifnaios added this to the v0.13.1 milestone Jul 15, 2025
@IoannisSifnaios
Copy link
Contributor Author

@AdamRJensen could you give some first feedback on this?

Also, should there also be a read_nasa_power function or not?

@AdamRJensen
Copy link
Member

Also, should there also be a read_nasa_power function or not?

I suggest just adding a get_nasa_power function for now. If there is a need for a read function, we can always add that later.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

@IoannisSifnaios IoannisSifnaios marked this pull request as ready for review July 16, 2025 13:49
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, overall looks pretty good to me! Seems like the API is a little slow but not terrible: 16 seconds for a year of data.

@IoannisSifnaios
Copy link
Contributor Author

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

@echedey-ls
Copy link
Contributor

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

@IoannisSifnaios that's due to the flags that make the iotools tests only run when explicitly requested. The pytest command you must run is in workflows/pytest-remote-data.yml:

run: pytest tests/iotools --cov=./ --cov-report=xml --remote-data

cov parameters are just for the coverage file, you don't need em.

@IoannisSifnaios
Copy link
Contributor Author

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

@IoannisSifnaios that's due to the flags that make the iotools tests only run when explicitly requested. The pytest command you must run is in workflows/pytest-remote-data.yml:

run: pytest tests/iotools --cov=./ --cov-report=xml --remote-data

cov parameters are just for the coverage file, you don't need em.

I guess based on the workflow description, there should also be a remote_data label added, right?

@echedey-ls
Copy link
Contributor

echedey-ls commented Jul 21, 2025

there should also be a remote_data label added, right?

Yup, that's right!

Edit: in fact, see it's one of the instructions (the last one) on the PR template

@IoannisSifnaios IoannisSifnaios added the remote-data triggers --remote-data pytests label Jul 21, 2025
@IoannisSifnaios IoannisSifnaios added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jul 28, 2025
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick in Whatsnew. LGTM 💯

@kandersolar
Copy link
Member

Thanks @IoannisSifnaios!

@kandersolar kandersolar merged commit 59d2e8e into pvlib:main Jul 30, 2025
30 checks passed
@IoannisSifnaios IoannisSifnaios deleted the add_nasa_power branch July 30, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants