Remove out-of-range warnings from pvlib.spectrum.spectral_factor_firstsolar
#2512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDaxini
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Somewhat (maybe) related discussion in #2086 on the limits (more so than the warnings) for further context in case anyone is interested.
Anyway LGTM, thanks for making this overdue change @kandersolar
Co-authored-by: RDaxini <[email protected]>
cwhanse
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The warnings emitted from
spectral_factor_firstsolarwere taken from the MATLAB version: https://github.com/sandialabs/MATLAB_PV_LIB/blob/master/pvl_FSspeccorr.m#L113Such warnings are not present elsewhere in pvlib-python. I've felt for a long time that they are out of place (see e.g. #1296 (comment) and #2072 (comment)). This PR proposes to remove the warnings.