Skip to content

Update references in inverter.py #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −7
Open

Update references in inverter.py #2531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pvlib/inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ def sandia(v_dc, p_dc, inverter):
References
----------
.. [1] D. King, S. Gonzalez, G. Galbraith, W. Boyson, "Performance Model
for Grid-Connected Photovoltaic Inverters", SAND2007-5036, Sandia
National Laboratories.

for Grid-Connected Photovoltaic Inverters", Sandia National
Laboratories, Albuquerque, N.M., USA, SAND2007-5036, Sept. 2007.
:doi:`10.2172/920449`
.. [2] System Advisor Model web page. https://sam.nrel.gov.
Copy link
Member

@RDaxini RDaxini Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could improve this reference as well. Looking at the citing SAM webpage, I can't see a specific reference for the database. If we just want a general reference, as the current reference is supposed to be, we could go for something like:

Suggested change
.. [2] System Advisor Model web page. https://sam.nrel.gov.
.. [2] System Advisor Model™ Version 2025.4.16 (SAM™ 2025.4.16). National Renewable Energy Laboratory. Golden, CO. Accessed August 13, 2025. https://sam.nrel.gov.

This is copied from the citing SAM webpage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should cite a particular verion of SAM, since pvlib doesn't promise that it distributes files from that version. Replacing the CEC module and inverter files with more up-to-date versions is #1345


See also
Expand Down Expand Up @@ -176,11 +176,13 @@ def sandia_multi(v_dc, p_dc, inverter):
References
----------
.. [1] D. King, S. Gonzalez, G. Galbraith, W. Boyson, "Performance Model
for Grid-Connected Photovoltaic Inverters", SAND2007-5036, Sandia
National Laboratories.
for Grid-Connected Photovoltaic Inverters", Sandia National
Laboratories, Albuquerque, N.M., USA, SAND2007-5036, Sept. 2007.
:doi:`10.2172/920449`
.. [2] C. Hansen, J. Johnson, R. Darbali-Zamora, N. Gurule. "Modeling
Efficiency Of Inverters With Multiple Inputs", 49th IEEE Photovoltaic
Specialist Conference, Philadelphia, PA, USA. June 2022.
:doi:`10.1109/PVSC48317.2022.9938490`

See also
--------
Expand Down Expand Up @@ -272,6 +274,7 @@ def adr(v_dc, p_dc, inverter, vtol=0.10):
.. [1] A. Driesse, "Beyond the Curves: Modeling the Electrical Efficiency
of Photovoltaic Inverters", 33rd IEEE Photovoltaic Specialist
Conference (PVSC), June 2008
:doi:`10.1109/PVSC.2008.4922827`

See also
--------
Expand Down Expand Up @@ -487,8 +490,9 @@ def fit_sandia(ac_power, dc_power, dc_voltage, dc_voltage_level, p_ac_0, p_nt):
References
----------
.. [1] D. King, S. Gonzalez, G. Galbraith, W. Boyson, "Performance Model
for Grid-Connected Photovoltaic Inverters", SAND2007-5036, Sandia
National Laboratories.
for Grid-Connected Photovoltaic Inverters", Sandia National
Laboratories, Albuquerque, N.M., USA, SAND2007-5036, Sept. 2007.
:doi:`10.2172/920449`
.. [2] Sandia Inverter Model page, PV Performance Modeling Collaborative
https://pvpmc.sandia.gov/modeling-steps/dc-to-ac-conversion/sandia-inverter-model/
.. [3] W. Bower, et al., "Performance Test Protocol for Evaluating
Expand Down
Loading