Skip to content

DISC model zenith threshold: allow user to specify value #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DISC model zenith threshold: allow user to specify value #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ def perez(surface_tilt, surface_azimuth, dhi, dni, dni_extra,
return sky_diffuse


def disc(ghi, zenith, datetime_or_doy, pressure=101325):
def disc(ghi, zenith, datetime_or_doy, pressure=101325, zenith_threshold=87.):
"""
Estimate Direct Normal Irradiance from Global Horizontal Irradiance
using the DISC model.
Expand All @@ -1094,6 +1094,9 @@ def disc(ghi, zenith, datetime_or_doy, pressure=101325):
pressure : numeric
Site pressure in Pascal.

zenith_threshold: numeric
Filtering threshold on zenith angles in decimal degrees.

Returns
-------
output : OrderedDict or DataFrame
Expand Down Expand Up @@ -1155,7 +1158,7 @@ def disc(ghi, zenith, datetime_or_doy, pressure=101325):

dni = Kn * I0

dni = np.where((zenith > 87) | (ghi < 0) | (dni < 0), 0, dni)
dni = np.where((zenith > zenith_threshold) | (ghi < 0) | (dni < 0), 0, dni)

output = OrderedDict()
output['dni'] = dni
Expand Down