Skip to content

update solar_position docstring #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2017
Merged

update solar_position docstring #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7b41d8
update solar_position docstring
mikofski May 25, 2017
820be74
Merge branch 'master' into spa_solarposition_mbars
mikofski Jun 2, 2017
e9f7c63
add note to whatsnew-0.4.5 about mbars in low-level spa.py module ONLY
mikofski Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/sphinx/source/whatsnew/v0.4.5.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Bug fixes
* Added lower accuracy formulas for equation of time, declination, hour angle
and solar zenith.
* Remove all instances of .ix (:issue:`322`)
* Update docstring in `pvlib.spa.solar_position` - change units of pressure to
millibars. *NOTE*: units of pressure in `pvlib.solar_position.spa_python` and
`pvlib.solar_position.spa_c` are still Pascals. This update should have no
effect on most users, since it only applies to the low-level `spa.py` module.
(:issue:`327`)


Enhancements
Expand Down
2 changes: 1 addition & 1 deletion pvlib/spa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ def solar_position(unixtime, lat, lon, elev, pressure, temp, delta_t,
elev : float
Elevation of location in meters
pressure : int or float
avg. yearly pressure at location in Pascals;
avg. yearly pressure at location in millibars;
used for atmospheric correction
temp : int or float
avg. yearly temperature at location in
Expand Down