Skip to content

Removes var w from _calc_d (Issue #344) #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2017
Merged

Removes var w from _calc_d (Issue #344) #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2127f7f
Removes var w from _calc_d
alainakafkes Jun 30, 2017
46b1a1a
Removes var w from other invocations of _calc_d
alainakafkes Jun 30, 2017
7804868
Adds _calc_d changes to API Changes in v0.4.6
alainakafkes Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/v0.4.6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Enhancements

API Changes
~~~~~~~~~~~

* Removed parameter w from _calc_d (:issue:`344`)

Documentation
~~~~~~~~~~~~~
Expand All @@ -29,3 +29,4 @@ Contributors

* Will Holmgren
* Uwe Krien
* Alaina Kafkes
4 changes: 2 additions & 2 deletions pvlib/clearsky.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ def simplified_solis(apparent_elevation, aod700=0.1, precipitable_water=1.,
g = _calc_g(w, aod700)

taud = _calc_taud(w, aod700, p)
d = _calc_d(w, aod700, p)
d = _calc_d(aod700, p)

# this prevents the creation of nans at night instead of 0s
# it's also friendly to scalar and series inputs
Expand Down Expand Up @@ -525,7 +525,7 @@ def _calc_taud(w, aod700, p):
return taud


def _calc_d(w, aod700, p):
def _calc_d(aod700, p):
"""Calculate the d coefficient."""

p0 = 101325.
Expand Down