-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add analytical azimuth method to solarposition.py. #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
52cfb3b
Add analytical azimuth method.
veronicaguo 5395164
Number linked references.
veronicaguo 4e56576
Add test for solar_azimuth_analytical.
veronicaguo c0698d4
Add an entry in the api.rst file.
veronicaguo e3c7530
Correct for different azimuth convention.
veronicaguo 9c2b89b
Update test tolerance.
veronicaguo b6d6fb9
Added an entry in the v0.4.6 whatsnew file.
veronicaguo d1b38b5
Update assert statements.
veronicaguo 2c346c4
Update threshold for `atol=0.55` assert statement.
veronicaguo 3728f15
Merge branch 'master' of github.com:pvlib/pvlib-python
veronicaguo 31bf30d
Update test, only when the sun is above horizon.
veronicaguo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veronicaguo and @wholmgren sorry for super late review, and just a tiny nitpick, but I don't think
np.abs
is necessary here because according to numpy documentation onnp.arccos
it is only defined from on[0, pi]
Therefore, it will never return a negative number, so no need for absolute value.