Skip to content

compatibility with pandas 0.24 deprecations #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2019
Merged

compatibility with pandas 0.24 deprecations #662

merged 3 commits into from
Feb 15, 2019

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Feb 15, 2019 •
edited
Loading

  • Closes change code for pandas DatetimeIndex kwargs deprecation #659
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.2 milestone Feb 15, 2019
@wholmgren wholmgren added the bug label Feb 15, 2019
@wholmgren wholmgren requested a review from cwhanse February 15, 2019 15:03
cwhanse
cwhanse reviewed Feb 15, 2019
View reviewed changes
pvlib/test/test_location.py
@@ -75,12 +75,16 @@ def test_location_print_pytz():
assert tus.__str__() == expected_str


@pytest.fixture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition

@wholmgren wholmgren merged commit 1ecef34 into pvlib:master Feb 15, 2019
@wholmgren wholmgren deleted the dtindex branch February 15, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@wholmgren @cwhanse