Skip to content

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Mar 19, 2019

  • Closes pvwatts_ac raises ZeroDivisionError for scalar pdc=0, RuntimeWarning for array(0) input #675
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added bug solarfx2 DOE SETO Solar Forecasting 2 / Solar Forecast Arbiter labels Mar 19, 2019
@wholmgren wholmgren added this to the 0.6.2 milestone Mar 19, 2019
Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clever usage of np.divide(..., where=...)

@wholmgren
Copy link
Member Author

@mikofski a stack overflow user gets the credit, as usual!

@wholmgren
Copy link
Member Author

@cwhanse go ahead and merge if this looks good to you too.

@cwhanse cwhanse merged commit bb0e0b4 into pvlib:master Mar 20, 2019
@wholmgren wholmgren deleted the pvwattsac0 branch March 20, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug solarfx2 DOE SETO Solar Forecasting 2 / Solar Forecast Arbiter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants