Skip to content

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented May 3, 2019

  • Closes PVWatts_loss was applied on AC calculation #696
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added the bug label May 3, 2019
@wholmgren wholmgren added this to the 0.6.2 milestone May 3, 2019
@wholmgren wholmgren merged commit 6946ef1 into pvlib:master May 13, 2019
@wholmgren wholmgren deleted the pvwattslosses branch May 13, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PVWatts_loss was applied on AC calculation
2 participants